Config removal #14
Merged
Config removal #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on the grounds that atom's own package management has the option to disable packages
|
Deleted code is the best kind of code; I'm only jealous I didn't get to do it ;-) In truth, we got fatigued tracking all the API changes leading up to the 1.0 and we started ignoring them as long as the plugin didn't completely blow up, so this is a very welcome PR. I'm looking at it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I hope you don't mind unsolicited pull requests, especially ones that are basically a big deletion?
I started off wanting to change the color of rulerz's ruler lines, which entailed adding a stylesheet rule. I then realised we could potentially set the width there too, but that was blocked by the "width" config overwriting it. So I forked and removed the width config. It seems to me that using the stylesheet is the Atom-y way of doing this kind of thing.
Then I realised the "enable" config option was surplus to requirement since atom has its own enable/disable in the package manager now. So I kinda deleted all the config subscriptions and replaced them with a note in the README.