Remove user specified search engine telemetry

fork-maintainers · Aug 31, 2021 · 19d8f58 · 19d8f58
1 parent 7653691
commit 19d8f58
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 47 deletions.
diff --git a/app/metrics.yaml b/app/metrics.yaml
@@ -3366,41 +3366,6 @@ logins:
       - android-probes@mozilla.com
     expires: "2022-02-01"
 
-user_specified_search_engines:
-  custom_engine_added:
-    type: event
-    description: |
-      A user added a new custom search engine
-    bugs:
-      - https://github.com/mozilla-mobile/fenix/issues/5884
-    data_reviews:
-      - https://github.com/mozilla-mobile/fenix/pull/6918
-      - https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068
-      - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789
-    data_sensitivity:
-      - interaction
-    notification_emails:
-      - android-probes@mozilla.com
-    expires: "2021-08-01"
-    no_lint:
-      - COMMON_PREFIX
-  custom_engine_deleted:
-    type: event
-    description: |
-      A user deleted a custom search engine
-    bugs:
-      - https://github.com/mozilla-mobile/fenix/issues/5884
-      - https://github.com/mozilla-mobile/fenix/issues/7881
-    data_reviews:
-      - https://github.com/mozilla-mobile/fenix/pull/6918
-      - https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068
-      - https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789
-    data_sensitivity:
-      - interaction
-    notification_emails:
-      - android-probes@mozilla.com
-    expires: "2021-08-01"
-
 search_suggestions:
   enable_in_private:
     type: event

diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt
@@ -124,8 +124,6 @@ sealed class Event {
     object EditLogin : Event()
     object EditLoginSave : Event()
     object ViewLoginPassword : Event()
-    object CustomEngineAdded : Event()
-    object CustomEngineDeleted : Event()
     object PrivateBrowsingShowSearchSuggestions : Event()
     object WhatsNewTapped : Event()
     object PocketTopSiteClicked : Event()

diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt
@@ -55,7 +55,6 @@ import org.mozilla.fenix.GleanMetrics.TabsTray
 import org.mozilla.fenix.GleanMetrics.ToolbarSettings
 import org.mozilla.fenix.GleanMetrics.TopSites
 import org.mozilla.fenix.GleanMetrics.TrackingProtection
-import org.mozilla.fenix.GleanMetrics.UserSpecifiedSearchEngines
 import org.mozilla.fenix.GleanMetrics.VoiceSearch
 import org.mozilla.fenix.ext.components
 
@@ -451,12 +450,6 @@ private val Event.wrapper: EventWrapper<*>?
             { ToolbarSettings.changedPosition.record(it) },
             { ToolbarSettings.changedPositionKeys.valueOf(it) }
         )
-        is Event.CustomEngineAdded -> EventWrapper<NoExtraKeys>(
-            { UserSpecifiedSearchEngines.customEngineAdded.record(it) }
-        )
-        is Event.CustomEngineDeleted -> EventWrapper<NoExtraKeys>(
-            { UserSpecifiedSearchEngines.customEngineDeleted.record(it) }
-        )
         is Event.SaveLoginsSettingChanged -> EventWrapper(
             { Logins.saveLoginsSettingChanged.record(it) },
             { Logins.saveLoginsSettingChangedKeys.valueOf(it) }

diff --git a/app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt
@@ -32,7 +32,6 @@ import org.mozilla.fenix.BrowserDirection
 import org.mozilla.fenix.HomeActivity
 import org.mozilla.fenix.R
 import org.mozilla.fenix.components.FenixSnackbar
-import org.mozilla.fenix.components.metrics.Event
 import org.mozilla.fenix.databinding.CustomSearchEngineBinding
 import org.mozilla.fenix.databinding.CustomSearchEngineRadioButtonBinding
 import org.mozilla.fenix.databinding.FragmentAddSearchEngineBinding
@@ -193,8 +192,6 @@ class AddSearchEngineFragment :
                             .setText(successMessage)
                             .show()
                     }
-
-                    context?.components?.analytics?.metrics?.track(Event.CustomEngineAdded)
                     findNavController().popBackStack()
                 }
             }