Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minify library #750

Closed
GhaziTriki opened this issue May 26, 2014 · 12 comments
Closed

Update minify library #750

GhaziTriki opened this issue May 26, 2014 · 12 comments

Comments

@GhaziTriki
Copy link
Contributor

When the website goes to production and the css gets minifed some display properties are lost and the display is not the same as developement. Is it worth switching to https://github.com/mrclay/minify ?

@jeroendesloovere
Copy link
Member

@ghazispeakserve Can you give us some details for whats going wrong? So we can check this out. Thanks.

@GhaziTriki
Copy link
Contributor Author

Yes of course. At the website https://babl.biz/en you can see that there is a gap between the menu and the slider images, this gap is not present in development version. The only difference between them is the minified CSS and I could not find the issue exactly.

@tijsverkoyen
Copy link
Member

👍

@WouterSioen
Copy link
Member

@ghazispeakserve Are you planning on doing a pull request to implement this feature?

@GhaziTriki
Copy link
Contributor Author

Hi Wouter,
Unfortunately not for now.

@GhaziTriki
Copy link
Contributor Author

We have developed two little websites with Fork CMS and we have this issue. We are now starting a new big project and the issue is still here. Can we plan a debugging session together?

@jessedobbelaere
Copy link
Member

A couple of days ago, the minifier was upgraded to the latest version. Maybe you could test that version?

@WouterSioen
Copy link
Member

We will release a new version of Fork containing the updated minifier
tomorrow.

Op zondag 19 oktober 2014 heeft Jesse Dobbelaere notifications@github.com
het volgende geschreven:

A couple of days ago, the minifier was upgraded
5d93044
to the latest version. Maybe you could test that version?


Reply to this email directly or view it on GitHub
#750 (comment).

@GhaziTriki
Copy link
Contributor Author

I have updated my minify library to "1.3.*" and things are worse. I get '(  ) characters in my CSS and I don't have any correct display. Would you think I should contact its developer to debug it together?

@WouterSioen
Copy link
Member

Poke @matthiasmullie

Op zondag 19 oktober 2014 heeft Ghazi Triki notifications@github.com het
volgende geschreven:

I have updated my minify library to "1.3.*" and things are worse. I get '(
 ) characters in my CSS and I don't have any correct display. Would you
think I should contact its developer to debug it together?


Reply to this email directly or view it on GitHub
#750 (comment).

@matthiasmullie
Copy link
Member

@ghazispeakserve Can you submit this issue at https://github.com/matthiasmullie/minify/issues
Please add an example with CSS that minifies incorrectly. I can take a look at it tomorrow.

@WouterSioen
Copy link
Member

@ghazispeakserve We'll close this issue here, since it is a matthiasmullie/minify issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants