Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimise RSS link #841

Closed
jeroendesloovere opened this issue Aug 18, 2014 · 2 comments
Closed

Minimise RSS link #841

jeroendesloovere opened this issue Aug 18, 2014 · 2 comments
Assignees

Comments

@jeroendesloovere
Copy link
Member

Feature Request

Why don't we add a new function addRssLink, so we can use:

// add RSS-feed
$this->header->addRssLink($rssTitle, $rssLink);

Instead of

// add RSS-feed
$this->header->addLink(
    array(
         'rel' => 'alternate',
         'type' => 'application/rss+xml',
         'title' => FrontendModel::getModuleSetting('Blog', 'rss_title_' . FRONTEND_LANGUAGE),
         'href' => $rssLink
    ),
    true
);

So we can remove redundant code

@jeroendesloovere
Copy link
Member Author

Closed because it is merged

@WouterSioen
Copy link
Member

@jeroendesloovere Thanks for closing these issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants