Replace SPOON_CHARSET by $container->getParameter('kernel.charset')

[jeroendesloovere]

Fixes #1138

[WouterSioen]

somebody's on a roll! 👍

[jeroendesloovere]

@WouterSioen If everybody continues to contribute its share of the pie. The symfony conversion will be over soon and w'll be able to create amazing sh*t!

[WouterSioen]

You went to fast here. The tests are failing. This could give you a hint: https://travis-ci.org/forkcms/forkcms/jobs/54884901

[jeroendesloovere]

Strange, I don't get any error in the backend. I even can use that truncate function without problems...
Could it be that Travis is wrong?

[jeroendesloovere]

Is it possible that it fails because 'kernel.charset' is not set in any parameters files (f.e.: parameters.yml.travis)

[WouterSioen]

Because it's a unit test, there is no backend model containing a container yet. I would do this: create a mock object "container" that returns 'UTF-8' when getParameter('kernel.charset') is called. Then do a "BackendModel::setContainer()" with this mock object.

If you need more info to create this, I'd be happy to help.

[WouterSioen]

You could do something like this:

$containerMock = $this
    ->getMockBuilder('Symfony\Component\DependencyInjection\ContainerInterface')
    ->disableOriginalConstructor()
    ->getMock()
;

$containerMock->expects($this->any())
    ->method('getParameter')
    ->with('kernel.charset')
    ->will($this->returnValue('UTF-8'))
;

BackendModel::setContainer($containerMock);

Something like this should work.

[WouterSioen]

Note that you should also be able to remove the defined('SPOON_CHARSET') || define('SPOON_CHARSET', 'UTF-8'); line

[WouterSioen]

And in the frontend the same for frontend.

[WouterSioen]

👍

[WouterSioen]

I'll squash and merge this

[WouterSioen]

merged