New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct check for blog detail revision #2696

Merged
merged 2 commits into from Dec 19, 2018

Conversation

Projects
None yet
2 participants
@StijnVrolijk
Copy link
Contributor

StijnVrolijk commented Dec 19, 2018

Type

  • Critical bugfix

Pull request description

getParameter returns null if the value isn't found. Therefor we need to check if it's null, not 0.

This caused all blog posts since Fork CMS 5.1.0 to not get cached by search engines. If this is something that is important to you, please fix this retroactively.

Thanks to @bramds for reporting the issue.

Use correct check for blog detail revision
getParameter returns `null` if the value isn't found

@StijnVrolijk StijnVrolijk added this to the 5.4.2 milestone Dec 19, 2018

@StijnVrolijk StijnVrolijk requested review from bramds and forkcms/core-contributors Dec 19, 2018

@carakas carakas merged commit 17d2d8a into master Dec 19, 2018

5 checks passed

Scrutinizer No new issues
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@carakas carakas modified the milestones: 5.4.2, 5.5.0 Dec 19, 2018

@carakas carakas deleted the fix-incorrect-meta-tags-in-blog branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment