Improve checking the use of SSL #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Servers that are behind a proxy will always have `%{HTTPS} === off`.
To prevent infinite redirect loops in this scenario this commit adds a
check on the
[X-Forwarded-Proto](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Proto)
header before defaulting back to the `%{HTTPS}` check. This should cover
about 99% of possible htaccess/ssl related scenarios.
jonasdekeukelaere
approved these changes
Mar 27, 2019
carakas
requested changes
Mar 27, 2019
carakas
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
Servers that are behind a proxy will always have
%{HTTPS} === off.To prevent infinite redirect loops in this scenario this commit adds a check on the X-Forwarded-Proto header before defaulting back to the
%{HTTPS}check. This should cover about 99% of possible htaccess/ssl related scenarios.