Bugfix for location widget - load google before location.js #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2012 13:45
…bug) Google has to be loaded before the location.js script. Because IE browsers can't handle this properly.
|
Can you give some more details? The location.js file is loaded before google.js but is executed when the document is loaded. |
|
"parent::execute()" needs to be loaded after "google.js", And if you don't do this, the location.js will be loaded before google.js (and then IE will give errors, because he can't find google.js)... Other browsers give no errors... |
|
This bugfix is added to the upcoming release (3.5). For the future: add new changelog items at the bottom of the changelog to preserve history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google has to be loaded before the location.js script.
Because IE browsers can't handle this properly.