New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update cobra #1
Commits on Nov 15, 2022
-
Create unit test illustrating unknown flag bug (spf13#1854)
Created a unit test that tests the unknown flag error message when the unknown flag is located in different arg positions.
Commits on Nov 22, 2022
Commits on Nov 25, 2022
-
Makefile: add target richtest (spf13#1865)
Don't require contributors to install richgo but keep it as an option and for CI
Commits on Nov 26, 2022
-
build(deps): bump golangci/golangci-lint-action from 3.2.0 to 3.3.1 (s…
…pf13#1851) Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.2.0 to 3.3.1. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3.2.0...v3.3.1) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Commits on Dec 6, 2022
-
Update kubescape org (spf13#1874)
Signed-off-by: David Wertenteil <dwertent@armosec.io>
Commits on Dec 9, 2022
-
ci: deprecate go 1.15 (spf13#1866)
Remove testing for go 1.15 to allow CI to pass, but don't force projects to upgrade.
Commits on Dec 15, 2022
-
fix: conflict import name with variable (spf13#1879)
`template` is an import in `cobra.go` file and also used as a variable name, which masks the library in the scope of that function.
Commits on Dec 23, 2022
Commits on Dec 25, 2022
-
fix: func name in doc strings (spf13#1885)
Corrected the function name at the start of doc strings, as per the convention outlined in official go documentation: https://go.dev/blog/godoc
Commits on Jan 3, 2023
-
completions: do not detect arguments with dash as 2nd char as flag (s…
…pf13#1817) Fixes spf13#1816 Previously, arguments with a dash as the second character (e.g., 1-ff00:0:1) were detected as a flag by mistake. This resulted in auto completion misbehaving if such an argument was last in the argument list during invocation.
Commits on Jan 30, 2023
Commits on Feb 6, 2023
Commits on Feb 9, 2023
-
Update shell_completions.md (spf13#1907)
align documentation with the code : completions.go:452
Commits on Feb 12, 2023
Commits on Feb 14, 2023
-
Removes stale bot from GitHub action (spf13#1908)
Signed-off-by: John McBride <jpmmcbride@gmail.com>
Commits on Feb 25, 2023
-
Add keeporder to shell completion (spf13#1903)
This allows programs to request the shell to maintain the order of completions that was returned by the program
-
Add support for PowerShell 7.2+ (spf13#1916)
PowerShell 7.2 has changed the way arguments are passed to executables. This was originally an experimental feature in 7.2, but as of 7.3 it is built-in. A simple "" is now sufficient for passing empty arguments, no back-tick escaping is required. Fixes spf13#1849 Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com> Co-authored-by: Oldřich Jedlička <oldrich.jedlicka@rohlik.cz>
Commits on Mar 6, 2023
Commits on Mar 14, 2023
-
Update projects_using_cobra.md (spf13#1932)
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Commits on Mar 17, 2023
-
Document suggested layout for subcommands (spf13#1930)
Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
Commits on Mar 22, 2023
-
Allow sourcing zsh completion script (spf13#1917)
Although it is not the recommended approach, sourcing a completion script is the simplest way to get people to try using shell completion. Not allowing it for zsh has turned out to complicate shell completion adoption. Further, many tools modify the zsh script to allow sourcing. This commit allows sourcing of the zsh completion script. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
-
Update main image to better handle dark background (spf13#1883)
Fixes spf13#1880 Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com> Co-authored-by: Deleplace <deleplace2015@gmail.com>
Commits on Apr 8, 2023
Commits on Jun 12, 2023
Commits on Jun 13, 2023
-
Fix grammar: 'allows to' (spf13#1978)
The use in generated bash completion files is getting flagged by Lintian (the Debian package linting tool). Signed-off-by: Taavi Väänänen <hi@taavi.wtf>
Commits on Jun 16, 2023
-
test: make fish_completions_test more robust (spf13#1980)
Use temporary files instead of assuming the current directory is writable. Also, if creating a temporary file still returns an error, prevent the test from failing silently by replacing `log.Fatal` with `t.Fatal`.
Commits on Jun 19, 2023
-
powershell: escape variable with curly brackets (spf13#1960)
This fixes an issue with program names that include a dot, in our case `podman.exe`. This was caused by the change in commit 6ba7ebb. Fixes spf13#1853 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Commits on Jun 20, 2023
Commits on Jul 16, 2023
Commits on Jul 18, 2023
Commits on Jul 20, 2023
Commits on Jul 23, 2023
Commits on Aug 28, 2023
Commits on Aug 29, 2023
Commits on Sep 8, 2023
Commits on Sep 26, 2023
Commits on Oct 9, 2023
Commits on Oct 15, 2023
Commits on Oct 16, 2023
Commits on Oct 22, 2023
-
Allow running persistent run hooks of all parents (spf13#2044)
Currently, only one of the persistent pre-runs and post-runs is executed. It is always the first one found in the parents chain, starting at this command. Expected behavior is to execute all parents' persistent pre-runs and post-runs. Dependent projects implemented various workarounds for this: - manually building persistent hook chains (in every hook). - applying some kind of monkey-patching on top of Cobra. This change eliminates the necessity for such workarounds by allowing to set a global variable EnableTraverseRunHooks. Tickets: - spf13#216 - spf13#252 Signed-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>
Commits on Oct 27, 2023
-
Fix linter errors (spf13#2052)
When using golangci-lint v1.55.0 some new errors were being reported. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
Commits on Oct 28, 2023
-
Don't complete --help flag when flag parsing disabled (spf13#2061)
Fixes spf13#2060 When a command sets `DisableFlagParsing = true` it requests the responsibility of doing all the flag parsing. Therefore even the `--help/-f/--version/-v` flags should not be automatically completed by Cobra in such a case. Without this change the `--help/-h/--version/-v` flags can end up being completed twice for plugins: one time from cobra and one time from the plugin (which has set `DisableFlagParsing = true`). Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
-
Add tests for flag completion registration (spf13#2053)
Different problems have been reported about flag completion registration. These two tests are the cases that were not being verified but had been mentioned as problematic. Ref: - spf13#1320 - spf13#1438 (comment) Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
Commits on Oct 29, 2023
-
Replace all non-alphanumerics in active help env var program prefix (s…
…pf13#1940) * Replace all non-alphanumerics in active help env var program prefix There are other characters besides the dash that are fine in program names, but are problematic in environment variable names. These include (but are not limited to) period, space, and non-ASCII letters. * Another change in docs to mention non-ASCII-alphanumeric instead of just dash
Commits on Oct 30, 2023
Commits on Nov 2, 2023
-
Support usage as plugin for tools like kubectl (spf13#2018)
In this case the executable is `kubectl-plugin`, but we run it as: kubectl plugin And the help text should reflect the actual usage of the command. To create a plugin, add the cobra.CommandDisplayNameAnnotation: rootCmd := &cobra.Command{ Use: "plugin", Annotations: map[string]string{ cobra.CommandDisplayNameAnnotation: "kubectl plugin", } } Internally this change modifies CommandPath() for the root command to return the command display name instead of the command name. This is used for error messages, help text generation, and completions. CommandPath() is expected to have spaces and code using it already handle spaces (e.g replacing with _), so hopefully this does not break anything. Fixes: spf13#2017 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
-
Improve API to get flag completion function (spf13#2063)
The new API is simpler and matches the `c.RegisterFlagCompletionFunc()` API. By removing the global function `GetFlagCompletion()` we are more future proof if we ever move from a global map of flag completion functions to something associated with the command. The commit also makes this API work with persistent flags by using `c.Flag(flagName)` instead of `c.Flags().Lookup(flagName)`. The commit also adds unit tests. Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>