fix: Fix http basic flag. #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 67.16% 69.48% +2.32%
==========================================
Files 72 75 +3
Lines 3816 3936 +120
==========================================
+ Hits 2563 2735 +172
+ Misses 1001 960 -41
+ Partials 252 241 -11
Continue to review full report at Codecov.
|
gfyrag
force-pushed
the
fix/http-basic-flag
branch
3 times, most recently
from
71b12fa
to
8271c69
Compare
antoinegelloz
previously approved these changes
Jun 27, 2022
altitude
reviewed
Jun 27, 2022
| expectedValue: "foo:bar", | ||
| }, | ||
| { | ||
| name: "using credentials flag", |
There was a problem hiding this comment.
Should this be authBasicCredentialsFlag ?
jdupas22
previously approved these changes
Jun 27, 2022
altitude
previously approved these changes
Jun 27, 2022
gfyrag
force-pushed
the
fix/http-basic-flag
branch
from
fd2bb50
to
5e41b21
Compare
It seems viper function RegisterAlias() does not works as expected, the GetStringSlice() function does not returns anything for any flag (the aliased as well as the alias). So the fix consist of not using RegisterAlias() and simply handle both flags. Also the PR move some bootstrap code from cmd/container.go and cmd/root.go inside package cmd/internal/http_basic.go. Now, all code related to http basic feature is located there.
gfyrag
force-pushed
the
fix/http-basic-flag
branch
from
5e41b21
to
6ad8354
Compare
antoinegelloz
approved these changes
Jun 27, 2022
jdupas22
approved these changes
Jun 27, 2022
flemzord
pushed a commit
that referenced
this pull request
Jun 7, 2023
flemzord
pushed a commit
that referenced
this pull request
Sep 20, 2023
flemzord
pushed a commit
that referenced
this pull request
Dec 4, 2023
flemzord
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fix http basic flag
It seems viper function RegisterAlias() does not works as expected, the GetStringSlice() function does not returns anything for any flag (the aliased as well as the alias).
So the fix consist of not using RegisterAlias() and simply handle both flags.
Also the PR move some bootstrap code from cmd/container.go and cmd/root.go inside package cmd/internal.
Now, all code related to http basic feature is located there.
Type of change
What parts of the code are impacted ?
Checklist:
I have made corresponding changes to the documentation