fix(@formatjs/cli): fix ID gen issue when description is undefined

formatjs · Jun 4, 2020 · 547d5b9 · 547d5b9
1 parent 13256b4
commit 547d5b9
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/packages/cli/src/extract.ts b/packages/cli/src/extract.ts
@@ -109,7 +109,11 @@ export async function extract(
                 resourcePath: filename,
               } as any,
               idInterpolationPattern,
-              {content: `${defaultMessage}#${description}`}
+              {
+                content: description
+                  ? `${defaultMessage}#${description}`
+                  : defaultMessage,
+              }
             ),
         };
       }

diff --git a/packages/cli/tests/extract/integration_tests/__snapshots__/index.test.ts.snap b/packages/cli/tests/extract/integration_tests/__snapshots__/index.test.ts.snap
@@ -276,6 +276,10 @@ Array [
     "description": "no ID",
     "id": "fAT9Q5",
   },
+  Object {
+    "defaultMessage": "No Desc",
+    "id": "Ot/V+Y",
+  },
   Object {
     "defaultMessage": "formatted message",
     "description": "foo",
@@ -355,6 +359,10 @@ Array [
     "description": "no ID",
     "id": "fAT9Q5",
   },
+  Object {
+    "defaultMessage": "No Desc",
+    "id": "Ot/V+Y",
+  },
   Object {
     "defaultMessage": "formatted message",
     "description": "foo",

diff --git a/packages/cli/tests/extract/integration_tests/typescript/actual.tsx b/packages/cli/tests/extract/integration_tests/typescript/actual.tsx
@@ -40,6 +40,9 @@ const msgs = defineMessages({
     description: 'no ID',
     defaultMessage: 'No ID',
   },
+  noDesc: {
+    defaultMessage: 'No Desc',
+  },
 } as const);
 
 async function foo() {