Rename components to Intl* #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
|
what about Format?, if we do Format instead of Intl, it will even facilitate the transition to FormatJS library in the future, isn't it? |
|
Yeah, honestly I'm on the fence about this. Since this is a component my initial thought is to use a noun-y name, whereas if it's a method then it would be a verb-y name. I will write up some more details on this decision and some other things I've been thinking as sort of an RFC. |
ericf
added a commit
to ericf/react-intl
that referenced
this pull request
Jan 21, 2015
This adds "Formatted" as a prefix to all React Intl Components. See: formatjs#65 for discussion Closes formatjs#64 Fixes formatjs#60
|
Closing in favor of #67 |
longlho
pushed a commit
that referenced
this pull request
Apr 27, 2020
This resolves an issue where the following, valid, JSX was causing
this plugin to throw an error:
```js
<FormattedMessage id={dynamicId} />
```
The above is now ignored by this plugin as there's no
`defaultMessage` to extract and it's assumed to be defined elsewhere.
Also, the ICU Message parse error is now exposed with this refactor.
Fixes #62
Fixes #63
Fixes #64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60