Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide progress bar toggle #1883

Merged
merged 2 commits into from
Jan 11, 2024
Merged

feat: hide progress bar toggle #1883

merged 2 commits into from
Jan 11, 2024

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented Jan 11, 2024

What does this PR do?

Fixes 1632

Screen-Recording-2024-01-11-at-10.28.26.AM.mp4

How should this be tested?

Go to settings > styling
Toggle Hide Progress Bar

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Jan 11, 2024 8:51am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 8:51am

Copy link
Contributor

github-actions bot commented Jan 11, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks you for the feature and the quick turnaround 💪
Can you please move the hideProgressBar flag from productOverwrites to styling?
(we are building a bigger overhaul of the survey styling and I think it makes sense to put all future stylings into this object as it is consistent with frontend, logic and the data model)

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks a lot for the changes; looks great! 😊

@mattinannt mattinannt added this pull request to the merge queue Jan 11, 2024
Merged via the queue into main with commit ff864e3 Jan 11, 2024
12 checks passed
@mattinannt mattinannt deleted the hide-progress-bar branch January 11, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants