-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: thank you card tweaks #1956
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Thank you for following the naming conventions for pull request titles! 🙏 |
@@ -186,6 +186,15 @@ export function Survey({ | |||
setQuestionId(prevQuestionId); | |||
onActiveQuestionChange(prevQuestionId); | |||
}; | |||
|
|||
const question = useMemo(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now we have a question
and a currentQuestion
/ currQues
that we use in different places.
Can we somehow manage to rename question
to currentQuestion
and only use this in all places? Or isn't this possible? But I think we need to do something to avoid the confusion and have one object that stores the current question that is shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruwang thanks for making the changes; it's much easier to read and understand now 😊💪
What does this PR do?
Fixes 1558
1773
Screen-Recording-2024-01-24-at-1.18.47.PM.mp4
Screen-Recording-2024-01-24-at-12.49.32.PM.mp4
How should this be tested?
Deactivate thank you card for in app surveys
Upload image to thank you card
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated