fix: thank you card tweaks #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
mattinannt
requested changes
Jan 24, 2024
| @@ -186,6 +186,15 @@ export function Survey({ | |||
| setQuestionId(prevQuestionId); | |||
| onActiveQuestionChange(prevQuestionId); | |||
| }; | |||
|
|
|||
| const question = useMemo(() => { | |||
There was a problem hiding this comment.
now we have a question and a currentQuestion / currQues that we use in different places.
Can we somehow manage to rename question to currentQuestion and only use this in all places? Or isn't this possible? But I think we need to do something to avoid the confusion and have one object that stores the current question that is shown.
mattinannt
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
@Dhruwang thanks for making the changes; it's much easier to read and understand now 😊💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes 1558
1773
Screen-Recording-2024-01-24-at-1.18.47.PM.mp4
Screen-Recording-2024-01-24-at-12.49.32.PM.mp4
How should this be tested?
Deactivate thank you card for in app surveys
Upload image to thank you card
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated