feat: expiresAt should only update on sync in js package

[ShubhamPalriwala]

What does this PR do?

the expiresAt now only gets updated when the sync happens with the Formbricks backend else it does not! Allowing for a much more updated client side data from the api

How should this be tested?

• Test A
• Test B

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		Mar 18, 2024 0:01am
formbricks-com	⬜️ Ignored (Inspect)	Visit Preview		Mar 18, 2024 0:01am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

packages/js/src/lib/initialize.ts

There are several instances where the same configuration object is being fetched multiple times within the same function. This can be improved by fetching the configuration once and reusing it.
Create Issue
See the diff
Checkout the fix

    const currentConfig = config.get();
    config.update({
      environmentId: currentConfig.environmentId,
      apiHost: currentConfig.apiHost,
      userId: currentConfig.userId,
      state: {
        ...currentConfig.state,
        attributes: { ...currentConfig.state.attributes, ...c.attributes },
      },
      expiresAt: currentConfig.expiresAt,
    });

git fetch origin && git checkout -b ReviewBot/Impro-b43fvp3 origin/ReviewBot/Impro-b43fvp3

packages/js/src/lib/person.ts

Similar to the previous suggestion, the configuration object is being fetched multiple times within the same function. This can be improved by fetching the configuration once and reusing it.
Create Issue
See the diff
Checkout the fix

    const currentConfig = config.get();
    config.update({
      environmentId: currentConfig.environmentId,
      apiHost: currentConfig.apiHost,
      userId: currentConfig.userId,
      state: {
        ...currentConfig.state,
        attributes: {
          ...currentConfig.state.attributes,
          [key]: value.toString(),
        },
      },
      expiresAt: currentConfig.expiresAt,
    });

git fetch origin && git checkout -b ReviewBot/Impro-7x9k9uo origin/ReviewBot/Impro-7x9k9uo

[mattinannt]

@ShubhamPalriwala thank you for this; looks great! :-)