Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simpler Sharing Page [Concept] #2361

Conversation

gupta-piyush19
Copy link
Contributor

@gupta-piyush19 gupta-piyush19 commented Mar 28, 2024

What does this PR do?

Simplifies the sharing page by using common component of analysis pages.

Fixes
https://linear.app/formbricks/issue/FOR-1977/[concept]-simpler-sharing-page

How should this be tested?

  • Create a survey and make the results public, then just view the results page in incognito, it should work without any error.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Mar 28, 2024

@gupta-piyush19 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gupta-piyush19 Thanks for the PR, looks good and works well 😊
I've just added a small check to the useMembershipRole hook to not call the api on the sharing page, other than that, LGTM!

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gupta-piyush19 Looks good :-) I only have one concern regarding the modification of the generic useMembershipRole hook:

packages/lib/membership/hooks/useMembershipRole.tsx Outdated Show resolved Hide resolved
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gupta-piyush19 thanks for the changes; looks good :-)
Please go ahead with the merge :-)

…piyush/for-1977-concept-simpler-sharing-page
@gupta-piyush19 gupta-piyush19 added this pull request to the merge queue Apr 9, 2024
Merged via the queue into formbricks:main with commit 015d4c7 Apr 9, 2024
9 of 11 checks passed
@gupta-piyush19 gupta-piyush19 deleted the piyush/for-1977-concept-simpler-sharing-page branch April 9, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants