Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shared cache for next caching #2426

Merged
merged 11 commits into from
Apr 11, 2024

Conversation

ShubhamPalriwala
Copy link
Contributor

@ShubhamPalriwala ShubhamPalriwala commented Apr 11, 2024

Closes https://github.com/formbricks/internal/issues/54

What does this PR do?

Uses a combination of:

  • Redis (for next caching)
  • Webdis (HTTP wrapper over redis) (for rate limiting in middleware due to the edge runtime)

A new env var:

REDIS_HTTP_INTERFACE_URL

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 11, 2024

@ShubhamPalriwala is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@ShubhamPalriwala ShubhamPalriwala marked this pull request as ready for review April 11, 2024 13:35
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thanks :-) looks much better and simpler than before!
A few small points:

apps/web/cache-handler.mjs Outdated Show resolved Hide resolved
apps/web/cache-handler.mjs Show resolved Hide resolved
kamal/deploy.yml Outdated Show resolved Hide resolved
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala Looks great! Thanks for making the changes :-)

@mattinannt mattinannt added this pull request to the merge queue Apr 11, 2024
Merged via the queue into formbricks:main with commit ee15c26 Apr 11, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants