-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds enterprise license check #2431
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Thank you for following the naming conventions for pull request titles! 🙏 |
…piyush/enterprise-license-check
…piyush/enterprise-license-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to implement a fallback that ensures that the license is not deactivated by accident? When the the key is recognized as not valid due to an error (e.g. ee.formbricks.com has an outage or is buggy) suddenly all users will have admin rights and can do stupid things.
Possible solutions to ensure that a downtime of the license server does not affect all Enterprise installations:
- Check the license status every hour, but only return invalid if it has never been valid in the past 6 hours
- Show annoying banners in the backend to warn users that the licence key is invalid and enterprise features will be deactivated soon
Thanks, @jonas-hoebenreich, for the suggestion. |
What does this PR do?
Adds enterprise license check by calling the formbricks enterprise server for validation
Fixes
How should this be tested?
IS_FORMBRICKS_CLOUD = 0
in .envENTERPRISE_LICENSE_KEY
provided by @jobenjada or @mattinannt/settings/enterprise
)Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated