Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The play() request was interrupted by a call to pause() #2465

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes https://github.com/formbricks/internal/issues/16
Before

Screen-Recording-2024-04-17-at-3.46.06.PM.mp4

After

Screen-Recording-2024-04-17-at-3.46.19.PM.mp4

Issue occurs when video.play and video.pause are called in very short time intervals, used debouncing to fix that

How should this be tested?

Change survey backgrounds too quickly
https://github.com/formbricks/formbricks/assets/67850763/6312f1d0-204f-4bb2-a906-bca919fb8daa

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 10:25am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 10:25am

Copy link
Contributor

github-actions bot commented Apr 17, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thank you for the fix :-) :-)

@mattinannt mattinannt added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit e8e701c Apr 17, 2024
12 checks passed
@mattinannt mattinannt deleted the sentry-issue branch April 17, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants