chore: Link survey mobile view #2493
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
|
Hey Dhru! Thanks, looks good. However, if I test it on my iPhone, I have to scroll up to see the survey:
Other than that, I like the filling out UX much better. Really easy within the thumb range :) |
…ks/formbricks into link-survey-mobile-view
|
Hey @jobenjada, Updated the PR 😊. For safari on mobile, there is an issue with the dynamic height of address bar, and due to which even though its |
There was a problem hiding this comment.
Hey Dhru!
Noticed two more things:
The bottom border corners shouldn't be rounded on mobile:
Secondly, we currently have uneven paddings for top and bottom (pt-6 and pb-3) which is good for Desktop and in-app.
On mobile, pls sync them so its pt-6 and pb-6
So should look like this:
Thanks a lot! :)
| @@ -40,5 +40,5 @@ export const SurveyInline = (props: Omit<SurveyInlineProps, "containerId">) => { | |||
| loadScript(); | |||
| }, [containerId, props, renderInline]); | |||
|
|
|||
| return <div id={containerId} className="h-full w-full" />; | |||
There was a problem hiding this comment.
did you test this well? Feels like it'd break the layout in other places ;)
…nk-survey-mobile-view
…ks/formbricks into link-survey-mobile-view
|
Hey @jobenjada , have updated the PR 😊 |
What does this PR do?
Fixes https://github.com/formbricks/internal/issues/62
It may break if you add too much content (long headline and description) in a question but it can be fixed with #2477
How should this be tested?
Test link survey on small devices
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated