-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Link survey mobile view #2493
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fde48ec
mobile view for link surveys
Dhruwang ce4d4c7
Merge branch 'main' of https://github.com/Dhruwang/formbricks into li…
Dhruwang 8dacd82
fix: preview
Dhruwang 8ec97ea
merged main
Dhruwang e91c5da
Merge branch 'main' into link-survey-mobile-view
jobenjada f01fb83
fix: safari scroll issue
Dhruwang e674f10
Merge branch 'link-survey-mobile-view' of https://github.com/formbric…
Dhruwang e9d1165
Merge branch 'main' into link-survey-mobile-view
jobenjada 441ccd0
Merge branch 'main' of https://github.com/Dhruwang/formbricks into li…
Dhruwang 2ad9783
fix: bottom border radius
Dhruwang a4fc9af
fix: padding
Dhruwang 702d07d
Merge branch 'link-survey-mobile-view' of https://github.com/formbric…
Dhruwang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,32 @@ | ||
import { useEffect, useState } from "preact/hooks"; | ||
|
||
import { SurveyInlineProps } from "@formbricks/types/formbricksSurveys"; | ||
|
||
import { Survey } from "./Survey"; | ||
|
||
export function SurveyInline(props: SurveyInlineProps) { | ||
const [isMobile, setIsMobile] = useState(window.innerWidth < 768); // Assuming 768px as a breakpoint for mobile | ||
|
||
useEffect(() => { | ||
const handleResize = () => { | ||
setIsMobile(window.innerWidth < 768); | ||
}; | ||
|
||
window.addEventListener("resize", handleResize); | ||
return () => window.removeEventListener("resize", handleResize); | ||
}, []); | ||
|
||
return ( | ||
<div id="fbjs" className="formbricks-form h-full w-full"> | ||
<Survey {...props} /> | ||
{isMobile ? ( | ||
<div className="flex h-screen w-full flex-col justify-end overflow-hidden"> | ||
<div className="max-h-[90vh] overflow-auto"> | ||
<Survey {...props} /> | ||
</div> | ||
</div> | ||
) : ( | ||
<Survey {...props} /> | ||
)} | ||
</div> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you test this well? Feels like it'd break the layout in other places ;)