fix: restored Add logo button #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
mattinannt
requested changes
Apr 26, 2024
There was a problem hiding this comment.
@Dhruwang thanks for the PR :-) A few points I noticed from looking at the code:
apps/web/app/(app)/environments/[environmentId]/settings/lookandfeel/components/EditLogo.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/(app)/environments/[environmentId]/settings/lookandfeel/components/EditLogo.tsx
Outdated
Show resolved
Hide resolved
| @@ -43,6 +43,11 @@ export const ClientLogo = ({ environmentId, product, previewSurvey = false }: Cl | |||
| ) : ( | |||
| <Link | |||
| href={`/environments/${environmentId}/settings/lookandfeel`} | |||
| onClick={(e) => { | |||
| if (!environmentId) { | |||
There was a problem hiding this comment.
Should we show the link in the first place if the environmentId is not set?
There was a problem hiding this comment.
Here link is actually the Add logo button
And when environmentId is not present, which is the case on look and feel page preview, there it would be better that we still show the Add Logo Link which on click scrolls down to Add Logo settings. What do you think ?🤔
Screen-Recording-2024-04-29-at-12.46.09.PM.mp4
mattinannt
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes https://github.com/formbricks/internal/issues/120
Additionally, replaced window.confirm modal with our
DeleteDialog, when removing a logoHow should this be tested?
Test survey Preview in survey Editor and on look and feel page
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated