Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes date picker question code from sideloading #2550

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

pandeymangg
Copy link
Contributor

What does this PR do?

Removes the unused sideload infrastructure code and moves the DatePicker question component to the regular components directory under the surveys package. The CSS file date-picker.css is still separate from the global.css file for easier future maintenance if we only intend to change the custom css for the date-picker question type.

Fixes 13 (issue)

How should this be tested?

  • Add a date question

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 2:33pm
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 2:33pm

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandeymangg Nice, looks much cleaner! :-) Thanks for this improvement :-)

@mattinannt
Copy link
Member

@pandeymangg Please take a look at accessibility and solve it so a user is able to navigate through the date question with the tab and space key.

@mattinannt mattinannt added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit fc5adde Apr 29, 2024
12 checks passed
@mattinannt mattinannt deleted the chore/remove-sideloading branch April 29, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants