Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image uploader on welcome card #2576

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented May 6, 2024

What does this PR do?

Fixes #2575

Screenshot 2024-05-06 at 4 55 12 PM

How should this be tested?

Add logo on welcome card

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 11:55am

@github-actions github-actions bot added the bug Something isn't working label May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@pandeymangg pandeymangg added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 7c388c9 May 6, 2024
13 checks passed
@pandeymangg pandeymangg deleted the welcome-card-image-issue branch May 6, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The Welcome Card displays an image when a logo gets added
2 participants