fix: Shuffled choices issue

[Dhruwang]

What does this PR do?

we used this piece of code to derive the question choices for multi select questions. If question contains some shuffleOption, it also shuffles and outputs the shuffled choices. Here question.choices is included in the dependency array, which changes when user changes the choice label in survey editor, which further triggers the recalculation of question choices, which agains shuffles the options

  const questionChoices = useMemo(() => {
    if (!question.choices) {
      return [];
    }
    const choicesWithoutOther = question.choices.filter((choice) => choice.id !== "other");
    if (question.shuffleOption) {
      return shuffleQuestions(choicesWithoutOther, question.shuffleOption);
    }
    return choicesWithoutOther;
  }, [question.choices, question.shuffleOption]);

So now we calculate the shuffled order only once in the beginning and when some choice is added or removed.

This PR also disables the DND for question choices when shuffleOption(randomize all or all except last) is selected.

Fixes #2622

How should this be tested?

Play with shuffle options

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		May 17, 2024 9:08am
formbricks-docs	⬜️ Ignored (Inspect)	Visit Preview		May 17, 2024 9:08am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[mattinannt]

@Dhruwang thanks for the great explanation in the issue description :-)
I tested the functionality and encountered a few smaller issues. Can you please take a look? 😊

[mattinannt]

@Dhruwang thanks for making the changes; works great!! :-)