feature/auto close survey #310
Conversation
…feature/auto-close-survey
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@moritzrengert thanks for the feature and for providing detailed screenshots 😊🙏 I have a few suggestions and bugs I would like you to solve first before we can merge:
- When auto-close is activated we need to display some kind of indicator to the user that the modal is closing automatically. My first idea was a reverse progress bar on top (in brand color) that starts full, gets smaller and ends empty when the number of seconds to auto-close elapsed.
-
I have a problem with auto-close when the survey is triggered by a button click: Create a survey that is triggered on an event that is send on button click, go to the app and click the button, the modal opens and auto-closes correctly. but when I press again the widget closes after a very short (random) time and I don't see the closing animation and it just disappears.
-
When edit the auto-close time, click into the input field, delete the current value (6) and then write another value (e.g. 2), I always get a 0 in front. I would like to have it without the 0:
- Please also fix the merge conflicts that just come up 😊
…feature/auto-close-survey
|
Fixed the mentioned bugs and added the countdown progress bar. 🙂
|
|
Please check the countdown behaviour in the SurveyPreview, as I was not sure about the expected result @mattinannt. |
There was a problem hiding this comment.
@moritzrengert thanks a lot for the changes 🤗 Works great and I am going to merge it now 😊
Only the stop-motion progressbar doesn't really feel nice, but I will let Johannes check if he can fix that with a smoother CSS animation.
* add option to aut-close a in-app survey --------- Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
What does this PR do?
Adds the option to set an autoClose delay in seconds, that closes the in-product survey if it is not hovered or clicked within the specified time. Also prepared the logic to include in the survey preview.
Type of change
How should this be tested?
Checklist
pnpm buildandpnpm lintand checked for build and linting errorsconsole.logsgit pull origin main