Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make.com integration #628

Merged
merged 8 commits into from
Sep 12, 2023
Merged

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented Aug 1, 2023

What does this PR do?

Fixes #599

  1. Adds make to formbricks Integration page
  2. Adds a new section for make.com in documentation
  3. Created an app for formbricks on make.com (under review) - Apps public link

Screenshot from 2023-08-01 12-03-49

make

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

Check Integration page and Integration docs
Check app on make.com

Checklist

  • Added a screen recording or screenshots to this PR
  • Filled out the "How to test" section in this PR
  • Read the contributing guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Aug 1, 2023

@Dhruwang is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@@ -22,6 +23,13 @@ export default function IntegrationsPage() {
description="Integrate Formbricks with 5000+ apps via Zapier"
icon={<Image src={ZapierLogo} alt="Zapier Logo" />}
/>
<Card
docsHref="https://formbricks.com/docs/integrations/make"
connectHref="https://zapier.com/apps/formbricks/integrations"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will replace the link with the make one, once app is approved

@jobenjada jobenjada self-assigned this Aug 1, 2023
@jobenjada jobenjada marked this pull request as draft August 1, 2023 15:14
@jobenjada
Copy link
Member

Great PR, well documented! 🙌

Updated the wording in the docs a bit and converted to Draft until we got the URL.

Good work!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@Dhruwang Dhruwang marked this pull request as ready for review September 7, 2023 08:52
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

📦 Next.js Bundle Analysis for @formbricks/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

📦 Next.js Bundle Analysis for @formbricks/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 74.11 KB (🟢 16 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@mattinannt
Copy link
Member

@jobenjada What's the status on this?

@Dhruwang
Copy link
Contributor Author

@mattinannt Its ready for review :)

@mattinannt mattinannt changed the title Make.com integration feat: Make.com integration Sep 12, 2023
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang Great job 🤗💪

@mattinannt mattinannt merged commit 6a88420 into formbricks:main Sep 12, 2023
4 of 9 checks passed
waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
* added documentation for make.com integration

* ran pnpm format

* update wording in docs

* updated docs for make integration

* updated connect link

---------

Co-authored-by: Johannes <johannes@formbricks.com>
Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
* added documentation for make.com integration

* ran pnpm format

* update wording in docs

* updated docs for make integration

* updated connect link

---------

Co-authored-by: Johannes <johannes@formbricks.com>
Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
* added documentation for make.com integration

* ran pnpm format

* update wording in docs

* updated docs for make integration

* updated connect link

---------

Co-authored-by: Johannes <johannes@formbricks.com>
Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Build make.com integration
3 participants