Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back button in link surveys follow logic jumps #668

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

mattinannt
Copy link
Member

@mattinannt mattinannt commented Aug 9, 2023

What does this PR do?

Fix back button in link surveys follow logic jumps

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How to test

  • Create a new link survey (ideally with logic jumps)
  • Fill out the link survey and check the response in Formbricks
  • Check if logic jumps work
  • Go back after following logic jumps
  • Reload the page in the middle of the survey and check if the survey continues and if following answers are stored correctly in the previous response

@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 7:42am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 7:42am

Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, see remarks in Slack

@jobenjada jobenjada merged commit 6f0a269 into main Aug 9, 2023
6 checks passed
@jobenjada jobenjada deleted the fix/FOR-1105 branch August 9, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants