Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button descendent button error #715

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

joyal007
Copy link
Contributor

What does this PR do?

This PR fixes button descendent button error in survey page in both mobile and desktop view

Fixes #711

Screenshot 2023-08-19 at 7 07 12 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Go to any survey page

Checklist

  • Added a screen recording or screenshots to this PR
  • Filled out the "How to test" section in this PR
  • Read the contributing guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

@vercel
Copy link

vercel bot commented Aug 19, 2023

@joyal007 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@jobenjada jobenjada self-assigned this Aug 21, 2023
@jobenjada jobenjada merged commit bed70be into formbricks:main Aug 21, 2023
0 of 2 checks passed
@jobenjada
Copy link
Member

Looks good, thanks a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Button descendent on button
2 participants