fix: smiley rating question now fits inside container #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
|
Hey! thanks for picking this up :) Looks like there is a space here: 
Pls make sure its centered and also covers the full width (like with the first smiley starting exactly where the label starts) Thanks! |
|
@ShubhamPalriwala please fix the spacing issues mentioned by Johannes :-) |
…shubham/for-1331-smiley-rating-question-with-10-elements-too-long-for
…shubham/for-1331-smiley-rating-question-with-10-elements-too-long-for
|
Made the row centrally aligned, should be good now 🤞🏼 @mattinannt please see if you can get the time to review this |
mattinannt
approved these changes
Oct 3, 2023
mattinannt
deleted the
shubham/for-1331-smiley-rating-question-with-10-elements-too-long-for
branch
waseemrabani
pushed a commit
to LuminosoInsight/formbricks
that referenced
this pull request
Feb 2, 2024
* fix: smily rating question fit inside container * wip * fix: make row center aligned
waseemrabani
pushed a commit
to LuminosoInsight/formbricks
that referenced
this pull request
Feb 2, 2024
* fix: smily rating question fit inside container * wip * fix: make row center aligned
waseemrabani
pushed a commit
to LuminosoInsight/formbricks
that referenced
this pull request
Feb 2, 2024
* fix: smily rating question fit inside container * wip * fix: make row center aligned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Smileys in Rating question were extending out of the container when 10 were selected! Added a check to reduce the size when they are 10 as for the other cases, it worked fine!
https://www.loom.com/share/cd2ffa75d46c412fbda5b51bf7676db0?sid=d7ed70f2-8a31-4ba9-ae9c-c6364c18f498
Type of change
How should this be tested?
Test the smileys in preview in mobile and modal
Checklist
pnpm buildconsole.logsgit pull origin main