Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Single Use Link Preview is not correctly functioning #938

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

heysagnik
Copy link
Contributor

What does this PR do?

Fixes the preview link.

Fixes #935

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Create a single use survey and try to preview.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Oct 4, 2023

@heysagnik is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the bug Something isn't working label Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@heysagnik heysagnik changed the title Single Use Link Preview is not correctly functioning fix: Single Use Link Preview is not correctly functioning Oct 4, 2023
@heysagnik
Copy link
Contributor Author

image

i guess this error is not because of my code?

@jobenjada
Copy link
Member

jobenjada commented Oct 4, 2023

Once merged, you'll get 50 Points for this fix 🔥

@mattinannt mattinannt merged commit d9f3df8 into formbricks:main Oct 4, 2023
5 of 9 checks passed
@heysagnik
Copy link
Contributor Author

@mattinannt if possible please add hacktoberfest-accepted label

waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
…#938)

* fixing the preview link

* Update LinkSingleUseSurveyModal.tsx
waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
…#938)

* fixing the preview link

* Update LinkSingleUseSurveyModal.tsx
waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
…#938)

* fixing the preview link

* Update LinkSingleUseSurveyModal.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Single Use Link Preview is not correctly functioning
4 participants