Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): page-tabs component #53

Closed
wants to merge 3 commits into from

Conversation

Kritik-J
Copy link

What does this PR do?

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at oss.gg
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Video

screen-capture.1.webm

Copy link

vercel bot commented Mar 27, 2024

@Kritik-J is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Mar 27, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@Kritik-J
Copy link
Author

Usage -

<PageTabs
  tabs={[
    { label: "Dashboard", href: "/dashboard" },
    { label: "Enroll", href: "/enroll" },
  ]}
/>

@jobenjada
Copy link
Member

hey! we already have page tabs

image

or what am I missing? 🤓

@jobenjada jobenjada closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants