Fixes for PHP 8.0 #598
Merged
Fixes for PHP 8.0 #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In php 8 method_exists' first value cannot default to null, must be object or string. Was throwing error: method_exists(): Argument formers#1 ($object_or_class) must be of type object|string, null given.
stayallive
requested changes
Nov 30, 2020
src/Former/Traits/Field.php
Outdated
| @@ -132,7 +132,7 @@ public function __call($method, $parameters) | |||
| } | |||
|
|
|||
| // Redirect calls to the Control Group | |||
| if (method_exists($this->group, $method) or Str::startsWith($method, 'onGroup')) { | |||
| if (method_exists($this->group ?: '', $method) or Str::startsWith($method, 'onGroup')) { | |||
There was a problem hiding this comment.
Wouldn't it make more sense to do it like this? No reason to check for an empty method name to exists because we know it will not exist right?
Suggested change
| if (method_exists($this->group ?: '', $method) or Str::startsWith($method, 'onGroup')) { | |
| if ((!empty($this->group) && method_exists($this->group, $method)) or Str::startsWith($method, 'onGroup')) { |
There was a problem hiding this comment.
Either works. Your version does the same, just a bit more expressive which might be a better. Possibly has better bc support with older PHP versions.
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In php 8 method_exists' first value cannot default to null, must be object or string.
Was throwing error: method_exists(): Argument #1 ($object_or_class) must be of type object|string, null given.