Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

[Guide] Add npm link instructions to contribution guide #20

Open
boygirl opened this issue May 6, 2016 · 4 comments
Open

[Guide] Add npm link instructions to contribution guide #20

boygirl opened this issue May 6, 2016 · 4 comments
Assignees

Comments

@boygirl
Copy link
Contributor

boygirl commented May 6, 2016

From @coopy on January 6, 2016 21:45

There are some gotchas when you're setting up the dev environment to contribute to the Victory ecosystem. Consider adding a script to help npm link clones of victory components.

Copied from original issue: FormidableLabs/victory#151

@boygirl boygirl self-assigned this May 6, 2016
@boygirl
Copy link
Contributor Author

boygirl commented May 6, 2016

From @coopy on January 21, 2016 0:31

This goes along with FormidableLabs/victory#145

@paulathevalley
Copy link
Contributor

Hi team! What’s the status on this issue? Is it still relevant? If yes, who will be on point for writing it?

@coopy
Copy link

coopy commented Oct 25, 2016

Lauren could write up a basic guide for npm linking regular Victory.
Imran has been going through some npm link pain for VictoryNative and
could add a section specifically for RN.

On October 24, 2016 at 12:31:30 PM, Paula Lavalle (notifications@github.com)
wrote:

Hi team! What’s the status on this issue? Is it still relevant? If yes, who
will be on point for writing it?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAwg26ginPaS_n1dEBDUQuMQFVBdTWKXks5q3QeMgaJpZM4IZB05
.

@ryan-roemer
Copy link
Member

Please include me in the work / planning on this as @jevakallio and I are also working through the RN modules / dev story.

@paulathevalley paulathevalley changed the title [Docs] Add npm link instructions to contribution guide [Guide] Add npm link instructions to contribution guide Nov 21, 2016
chrisbolin pushed a commit that referenced this issue Mar 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants