Fix performance of dictionary check for longer passwords #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formigarafa
changed the title
result seems to be O(N) instead of O^N which is much better. raised with: https://github.com/twosixlabs/acsploit
formigarafa
force-pushed
the
fix-performance-of-l33t-match
branch
from
c8d886c
to
6bf5419
Compare
formigarafa
force-pushed
the
fix-performance-of-l33t-match
branch
from
f392f12
to
5ac4895
Compare
This was referenced Jan 27, 2023
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6 and makes the algorithm to have a linear response time
O(n)in relation to the size of the password instead of an polynomialO(n^C)as it used to as reported by https://github.com/twosixlabs/acsploit.Thanks to @Tostino for bringing this up.