Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7429: Remove columns component settings(pull, offset, push) #5384

Merged

Conversation

mikekotikov
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7429

Description

What changed?

Previously, formio.js Columns component had width, offset, push and pull bootstrap classes adjustments through component settings. This PR leaves only the width property adjustable, leaving ability to configure all the classes through component JSON schema.

Why have you chosen this solution?

Although there were many potential solutions such as ..., [my solution] was best because ...

Dependencies

@formio/bootstrap:80

How has this PR been tested?

Manually through formio-app UI

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@TanyaGashtold TanyaGashtold merged commit cb68631 into master Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants