Fix qwik intergration build #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Open
|
@FlatMapIO sent you a PR to your upstream repo. We’re not currently interested in converting this project into a monorepo with workspaces for just the qwik integration, but I’ve sent a PR to you with the rollup version. That said, it still doesn’t work in an actual clean qwik project so I think it needs more work. |
Unifies build system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#142 is an incorrect integration. The qwik library must be build by vite and @builder.io/qwik/optimizer, so I move the qwik integration to packages/qwik. This also has the advantage of having a Demo that can run directly and is easy to test the results