-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Add Theme toggle in Header
#20
[Feature]: Add Theme toggle in Header
#20
Conversation
@romanhrynevych is attempting to deploy a commit to the Formkit Team on Vercel. A member of the Team first needs to authorize it. |
Appreciate all the work here @romanhrynevych – for the most part this looks good — although im not sure we really want This will also save a bunch on page weight since we wont need a datepicker. Also, FWIW, if we were going to use a datepicker, we’d use FormKit’s: https://formkit.com/inputs/datepicker which actually uses Tempo to power it. So in summary, if you break this up into 2 small PRs I’ll gladly merged:
Thanks! |
Header
@justin-schroeder this PR will fix your first issue with
|
Sorry friend — haha — just don’t think I really want to add shadcn and all the related css and ~30 components to make that dropdown. Can we just do a little hand coding for that one? |
ah, ok, I will remove |
@justin-schroeder removed |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@romanhrynevych looks like it needs an pnpm install and commit of the lockfile |
66c4cbe
into
formkit:feature/dark-mode-toggle
This PR fixes #8
Added Select for change All
new Date()
code variables to custom, default value isnew Date()
previously:Added Theme DropDown so we can dynamically change theme on site:
Resolve issue with logical understanding of this comment #8 (comment):
All UI elements was added from https://github.com/radix-vue/shadcn-vue to ship it fast and with no errors 🙂