-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FeatureReuet: Support for the timezone token "ZZ" and changing the timezone format … #52
FeatureReuet: Support for the timezone token "ZZ" and changing the timezone format … #52
Conversation
@Toru-Takagi is attempting to deploy a commit to the Formkit Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you @Toru-Takagi. I think this is quite close — I think it might need some additional help on the parsing. Can you add some tests for using |
Thank you for the review. 🙇 When running the following test with the current code, the result is similar to what's commented out.
Is this the result you were expecting? or first: Success, second: Success, third: Success I apologize for bothering you while you're busy, but I'm looking forward to your response. |
Correct @Toru-Takagi, my expectation of those tests would be: Success, Fail, Success |
@justin-schroeder Similarly, should passing [+-]HHmm when FormatStyle is full result in an error, or should it succeed? |
@Toru-Takagi I think Now that I think about it — with this change formats that output formatStr({ time: 'full' }, 'en')
// h:mm:ss A Z The above should probably output |
I've made some corrections. |
This looks good @Toru-Takagi, merging this into the next release. I think I will tweak the time style so |
* feat: diff functions * differenceInMilliseconds * created the other constant difference functions, but will need to add the option 'ignoreTime' for day/week version * created the other constant difference functions * completing tests * adding differenceInX exports in index * make sure that rounding doesn't give -0 * added difference In Months & years * shortened the all difference functions to diffX moved using monthDays at diffMonths after `if (ld < rd)` * raname type DifferenceRoundingMethod -> DiffRoundingMethod * docs: adds diffs to docs * chore: bumps tests to latest actions * feat: existing "Z" token is now "ZZ" adds "Z" token style (#52) * Support for the timezone token "ZZ" and changing the timezone format style. * Fix timezone offset parsing and applyOffset function * chore: adjusts time format < full to be ZZ --------- Co-authored-by: WilcoSp <17604138+WilcoSp@users.noreply.github.com> Co-authored-by: Kouta Motegi <toru.takagi.engineer@gmail.com>
close #46
I've implemented the feature you previously requested.
I apologize for the inconvenience during your busy schedule, but I would appreciate it if you could check it.
If there are any issues, I would like feedback. I will consider making corrections or closing the PR.