This repository has been archived by the owner on Jun 5, 2023. It is now read-only.
Allow option to save config files in Google Cloud Storage. #4
Comments
|
Deprecated by PR #13 |
arbeit
added a commit
to arbeit/forseti-security
that referenced
this issue
Mar 27, 2018
blueandgold
pushed a commit
that referenced
this issue
Mar 27, 2018
…1290) * Add test to show that no empty notifications are sent * work in progress * fixed test * better test data * Use test data from the fake_violations module * address review comments, fix up test data * addressing review comments, batch #2 * addressing review comments, batch #3 * addressing review comments, batch #4 * addressing review comments, batch #5 * addressing review comments, batch #6
arbeit
added a commit
to arbeit/forseti-security
that referenced
this issue
Apr 10, 2018
blueandgold
pushed a commit
that referenced
this issue
Apr 25, 2018
* Added scanner_index_id to violations * Fix failing tests * A first test for the scanner run() function * Second test * minor fix * better test setup * Revert inadvertent change * Add test for init_scanner_index_id() * minor fixes * better name for the new column * added failing test for violation_access.list() * ViolationAccess.list() only returns most recent data The list() method now observes the 'scanner_start_time' column and only returns violations records that were added by the most recent scanner run. * Better tests * Fix pylint warning ************* Module google.cloud.forseti.notifier.notifier R:158, 4: Redefinition of violations type from list to dict (redefined-variable-type) * More complete doc string * Added ScannerIndex class / table * Revert changes to base scanner * Revert changes to scanner builder * Revert changes to notifier * adjust column names/queries * Initialize the 'scanner_index' table before scanner run * fix tests * more test fixes * test & pylint fixes * minor fix * mark scanner_index complete * added test for mark_scanner_index_complete() * better test * review comments, batch #1 * reverse changes to util/db.py * review comments, batch #2 * review comments, batch #3 * review comments, batch #4 * pylint fix * doc string fix * review comments, batch #5 * revert changes to scanners/base_scanner.py * Added test * last_scanner_index() looks at completed db rows by default * better test * added test * reworked violation_access.list() It now distinguishes the following cases: - both the inventory and the scanner index are set - either the inventory or the scanner index is set - neither the inventory nor the scanner index is set * fix tests * Tests for the violation_access.list() method * Handle the case where violation_access.create() is not passed a scanner index. * We want the most recent 'CREATED' scanner index. * Capture result/errors of the scanner run properly * minor fix * review comments, batch #6 * review comments, batch #7 * list() method now supports the inventory index * Tests for ViolationAccess.list() * Proper instantiation of ViolationAccess * Clean up access to 'violation_access' :) * Fix findings test * Fix tests * pylint fixes * fix column name * Flush the sql alchemy session after each scanner * fix column name * call list() with correct param * pylint fixes * morepylint fixes * Expunge violation rows to avoid subsequent db errors * Remove unneeded import * review comments, batch #8 * review comments, batch #9 * fix typo * review comments, batch #10 * pylint fixes * more tests * better error message * Fix the findings result data The scanner_index_id is added but the inventory_index_id needs to stay. * Make code IDE debugger friendly * better query & pylint fixes * better definition of the list() method * better doc string * reviewer changes * changes requested by reviewer * fix tests * add initializer param * convert_to_timestamp() operates on dicts now. Since we do *not* manipulate SQLAlchemy objects any more the need to expunge them from the session is not given any more. * changes requested by reviewer * changes requested by reviewer * changes requested by reviewer * Update notifier.py Change the literal, and updated method doc. * Update notifier.py add blank line in method doc
ocervell
pushed a commit
that referenced
this issue
Nov 29, 2018
Reverts merging 'dev' to 'adding-spans-forseti' Adds more guards for tracing Fixes breaking tests in run_inventory More detailed docstrings
Merged
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This applies to the config files in /config directory.
/config/db.yaml.sample/config/inventory.yaml.sampleCurrently, they are stored and read from local disk. But we run the risk of losing them on re-deployment. So to prevent this and with the benefit of easier deployment, we should allow an option to store and read them from Google Cloud Storage.
The text was updated successfully, but these errors were encountered: