Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Create some rules documentation #1

Merged
merged 2 commits into from Feb 19, 2017
Merged

Create some rules documentation #1

merged 2 commits into from Feb 19, 2017

Conversation

carise
Copy link
Contributor

@carise carise commented Feb 18, 2017

No description provided.

@carise carise merged commit aa54cf8 into master Feb 19, 2017
@carise carise deleted the rules-doc branch February 19, 2017 01:14
@carise carise mentioned this pull request Aug 23, 2017
Closed
@ahoying ahoying mentioned this pull request Oct 11, 2017
Closed
arbeit added a commit to arbeit/forseti-security that referenced this pull request Feb 14, 2018
@arbeit
addressing review comments, batch forseti-security#1
6143885
blueandgold pushed a commit that referenced this pull request Feb 16, 2018
@arbeit @blueandgold
Support iam policy member of domain type in iam scanner's required mo…
6a3bc81 
…de, (#1093)

* removed unused imports

* add failing test

* added (domain membership) test with wildcard user

* added domain membership check

* handle rsplit() hiccups

* better naming

* less confusing example

* addressing review comments, batch #1

* addressing review comments, batch #2
arbeit added a commit to arbeit/forseti-security that referenced this pull request Mar 26, 2018
@arbeit
review comments, batch forseti-security#1
3119daf
blueandgold pushed a commit that referenced this pull request Mar 27, 2018
@arbeit @blueandgold
Allow user to specify the violation payload format (csv / json) (#1301)
ca9c013 
* Added test for GCS upload with json/csv respectively

* pylint fixes

* implement csv/json uploads, fix tests/test data

* test for invalid data format

* minor fix

* Make _get_output_filename() observe the data format

* Make _get_output_filename() simpler

* Move _get_output_filename() into the base class

This will facilitate reuse of the same method in the EmailViolations
class.

* Use the base class _get_output_filename() method

Also, add a method that creates the attachment in json format.

* implement csv/json format; fix tests & test data

* pylint fix

* Better test coverage

* better naming

* review comments, batch #1

* review comments, batch #2

* fix custom exception class

* review comments, batch #3

* minor fix

* Remove redundant error log

* Update email_violations.py
arbeit added a commit to arbeit/forseti-security that referenced this pull request Apr 10, 2018
@arbeit
review comments, batch forseti-security#1
8983e49
arbeit added a commit that referenced this pull request Apr 17, 2018
@arbeit
review comments, batch #1
f9c1e8d
blueandgold pushed a commit that referenced this pull request Apr 25, 2018
@arbeit @blueandgold
Only notify of violations from the most recent scanner run (#1352)
3efdaa9 
* Added scanner_index_id to violations

* Fix failing tests

* A first test for the scanner run() function

* Second test

* minor fix

* better test setup

* Revert inadvertent change

* Add test for init_scanner_index_id()

* minor fixes

* better name for the new column

* added failing test for violation_access.list()

* ViolationAccess.list() only returns most recent data

The list() method now observes the 'scanner_start_time' column and only
returns violations records that were added by the most recent scanner
run.

* Better tests

* Fix pylint warning

************* Module google.cloud.forseti.notifier.notifier
R:158, 4: Redefinition of violations type from list to dict (redefined-variable-type)

* More complete doc string

* Added ScannerIndex class / table

* Revert changes to base scanner

* Revert changes to scanner builder

* Revert changes to notifier

* adjust column names/queries

* Initialize the 'scanner_index' table before scanner run

* fix tests

* more test fixes

* test & pylint fixes

* minor fix

* mark scanner_index complete

* added test for mark_scanner_index_complete()

* better test

* review comments, batch #1

* reverse changes to util/db.py

* review comments, batch #2

* review comments, batch #3

* review comments, batch #4

* pylint fix

* doc string fix

* review comments, batch #5

* revert changes to scanners/base_scanner.py

* Added test

* last_scanner_index() looks at completed db rows by default

* better test

* added test

* reworked violation_access.list()

It now distinguishes the following cases:
    - both the inventory and the scanner index are set
    - either the inventory or the scanner index is set
    - neither the inventory nor the scanner index is set

* fix tests

* Tests for the violation_access.list() method

* Handle the case where violation_access.create() is not passed a scanner
index.

* We want the most recent 'CREATED' scanner index.

* Capture result/errors of the scanner run properly

* minor fix

* review comments, batch #6

* review comments, batch #7

* list() method now supports the inventory index

* Tests for ViolationAccess.list()

* Proper instantiation of ViolationAccess

* Clean up access to 'violation_access' :)

* Fix findings test

* Fix tests

* pylint fixes

* fix column name

* Flush the sql alchemy session after each scanner

* fix column name

* call list() with correct param

* pylint fixes

* morepylint fixes

* Expunge violation rows to avoid subsequent db errors

* Remove unneeded import

* review comments, batch #8

* review comments, batch #9

* fix typo

* review comments, batch #10

* pylint fixes

* more tests

* better error message

* Fix the findings result data

The scanner_index_id is added but the inventory_index_id needs to stay.

* Make code IDE debugger friendly

* better query & pylint fixes

* better definition of the list() method

* better doc string

* reviewer changes

* changes requested by reviewer

* fix tests

* add initializer param

* convert_to_timestamp() operates on dicts now.

Since we do *not* manipulate SQLAlchemy objects any more the need to
expunge them from the session is not given any more.

* changes requested by reviewer

* changes requested by reviewer

* changes requested by reviewer

* Update notifier.py

Change the literal, and updated method doc.

* Update notifier.py

add blank line in method doc
@bkudzia bkudzia mentioned this pull request Aug 16, 2018
Closed
red2k18 pushed a commit that referenced this pull request Nov 13, 2018
@red2k18
Spans (#1)
f2757cf 
* Try updating spans

* Remove need for tracer in client.py

* Update

* Update

* Update

* Add threading support

* Remove unused var

* Update

* Update

* Update inventory

* Update inventory.py

* Update inventory.py

* Update inventory.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update tracing.py

* Update crawler.py

* Update crawler.py

* Update inventory.py

* Update inventory.py

* Update inventory.py

* Update inventory.py

* Update inventory.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update tracing.py

* Update crawler.py

* Update crawler.py

* Update crawler.py

* Update crawler.py
@blueandgold blueandgold mentioned this pull request Jan 7, 2019
Merged
6 tasks
@umairidris umairidris mentioned this pull request Feb 28, 2019
Merged
5 tasks
@blueandgold blueandgold mentioned this pull request Aug 1, 2019
Merged
6 tasks
This was referenced Aug 19, 2019
Closed
Merged
This was referenced Oct 7, 2019
Closed
Closed
@gkowalski-google gkowalski-google mentioned this pull request Nov 11, 2019
Closed
6 tasks
@blueandgold
Copy link
Contributor

blueandgold commented Nov 27, 2019 •
edited

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.

@blueandgold blueandgold mentioned this pull request Jan 21, 2020
Merged
gkowalski-google pushed a commit that referenced this pull request Jul 10, 2020
@berggren @hacktobeer
Refactor Forensics Terraform (#3762)
a359621 
* Depend on

* style fix

* Python3

* NEed more scopes and test

* Timesketch upload limit

* Deploy script

* test australia zone

* test australia zone

* us-central

* disable turbinia

* use TS release

* fix

* enable turbinia

* fix

* Increase timeout for cloudfunctions

* Add bucket pubsub notifiaction

* Add GCS importer

* Bugfix

* ES 7.x

* ES 7.x fixes

* ES 7.x fixes

* ES 7.x fixes

* ES 7.x fixes

* ES 7.x fixes

* ES 7.x fixes

* Wait for TS

* Depends

* deploy

* deploy

* deploy

* deploy

* deploy

* Move cloud functions to deploy.sh

* Move to the dockerized version of Turbinia. (#1)

* Add dockerized Turbinia Server configuration.

* change template variable

* base64 encode configuration

* add local. to var

* lcols

* Add turbninia-worker docker config

* Add cloud-platform scope to worker

* Moved variables to seperate file.

* Update docker registry URI.

* Small fix, remove var.

* Use standard cos-stable container image.

Co-authored-by: Johan Berggren <jberggren@gmail.com>

* cleanup

* Disable worker docker

* test worker docker

* test worker docker

* worker in docker

Co-authored-by: hacktobeer <ramsesdebeer@gmail.com>
@jbcraig jbcraig mentioned this pull request Aug 27, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carise @blueandgold