Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Allow user to specify the violation payload format (csv / json) #1301

Merged
merged 22 commits into from
Mar 27, 2018
Merged

Allow user to specify the violation payload format (csv / json) #1301

merged 22 commits into from
Mar 27, 2018

Commits on Mar 24, 2018

  1. Added test for GCS upload with json/csv respectively

    @arbeit
    arbeit committed Mar 24, 2018
    Configuration menu
    Copy the full SHA
    fe71b1a View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2018

  1. pylint fixes

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    5f717a4 View commit details
    Browse the repository at this point in the history

  2. implement csv/json uploads, fix tests/test data

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    3c63f37 View commit details
    Browse the repository at this point in the history

  3. minor fix

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    769018c View commit details
    Browse the repository at this point in the history

  4. test for invalid data format

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    0aac45c View commit details
    Browse the repository at this point in the history

  5. Make _get_output_filename() observe the data format

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    1f7b29b View commit details
    Browse the repository at this point in the history

  6. Make _get_output_filename() simpler

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    28ee1c4 View commit details
    Browse the repository at this point in the history

  7. Move _get_output_filename() into the base class 

    This will facilitate reuse of the same method in the EmailViolations
class.
    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    b5b92f8 View commit details
    Browse the repository at this point in the history

  8. Use the base class _get_output_filename() method 

    Also, add a method that creates the attachment in json format.
    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    01c8b27 View commit details
    Browse the repository at this point in the history

  9. implement csv/json format; fix tests & test data

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    59a595c View commit details
    Browse the repository at this point in the history

  10. pylint fix

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    7f61d0c View commit details
    Browse the repository at this point in the history

  11. Better test coverage

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    368df57 View commit details
    Browse the repository at this point in the history

  12. better naming

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    5af92d2 View commit details
    Browse the repository at this point in the history

  13. Merge branch '2.0-dev' into cvs-or-json-1287

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    cecf5c9 View commit details
    Browse the repository at this point in the history

  14. review comments, batch forseti-security#1

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    3119daf View commit details
    Browse the repository at this point in the history

  15. review comments, batch forseti-security#2

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    31f1175 View commit details
    Browse the repository at this point in the history

  16. fix custom exception class

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    9af2655 View commit details
    Browse the repository at this point in the history

  17. review comments, batch forseti-security#3

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    56a75b4 View commit details
    Browse the repository at this point in the history

  18. minor fix

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    b6eef3a View commit details
    Browse the repository at this point in the history

  19. Remove redundant error log

    @arbeit
    arbeit committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    17d11fa View commit details
    Browse the repository at this point in the history

  20. Update email_violations.py

    @blueandgold
    blueandgold committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    210e9c7 View commit details
    Browse the repository at this point in the history

  21. Merge branch '2.0-dev' into cvs-or-json-1287

    @blueandgold
    blueandgold committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    b8c50cb View commit details
    Browse the repository at this point in the history