Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Default asset types in CAI export to only assets Forseti supports. #2438

Merged
merged 3 commits into from
Dec 20, 2018

Conversation

ahoying
Copy link
Collaborator

@ahoying ahoying commented Dec 20, 2018

Request from Cloud Asset team to default to limiting asset types to only those used.

Thanks for opening a Pull Request!

Here's a handy checklist to ensure your PR goes smoothly.

  • I signed Google's Contributor License Agreement
  • My code conforms to Google's python style.
  • My PR at a minimum doesn't decrease unit-test coverage (if applicable).
  • My PR has been functionally tested.
  • All of the unit-tests still pass.
  • Running pylint --rcfile=pylintrc passes.

These guidelines and more can be found in our contributing guidelines.

Copy link
Contributor

@joecheuk joecheuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the comment in the config file since we are not exporting everything any more?

https://github.com/GoogleCloudPlatform/forseti-security/blob/a2aa7b04f0cf741767752f55a2fd6f4013e0dece/configs/server/forseti_conf_server.yaml.in#L96

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #2438 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #2438      +/-   ##
==========================================
+ Coverage   88.57%   88.57%   +<.01%     
==========================================
  Files         180      180              
  Lines       14117    14120       +3     
==========================================
+ Hits        12504    12507       +3     
  Misses       1613     1613
Impacted Files Coverage Δ
...loud/forseti/services/inventory/base/cloudasset.py 100% <100%> (ø) ⬆️

@ahoying
Copy link
Collaborator Author

ahoying commented Dec 20, 2018

Good call, done.

Copy link
Contributor

@joecheuk joecheuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@ahoying ahoying merged commit 3eeea92 into dev Dec 20, 2018
@ahoying ahoying deleted the cai-limit-assettypes branch December 20, 2018 23:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants