This repository has been archived by the owner on Jun 5, 2023. It is now read-only.
Updated CFT Docker image to add support for Terraform G Suite provider #3299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueandgold
reviewed
Oct 10, 2019
.travis.yml
Outdated
| @@ -37,19 +37,19 @@ jobs: | |||
| name: Integration test - docker | |||
| # Check on cron ensures build for integration tests is triggered only when | |||
| # cron job runs on dev branch. This cron job is currently set to run daily. | |||
| if: type = cron | |||
| # if: type = cron | |||
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
It was commented out to ensure build passes with new docker image, and it has been verified that it works as expected.
Build passed: https://travis-ci.org/forseti-security/forseti-security/builds/596207609?utm_source=github_status&utm_medium=notification
Uncommented the cron job check.
blueandgold
approved these changes
Oct 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.