add service account fields to firewall type throughout forseti

[RajUmadas]

Thanks for opening a Pull Request!

Here's a handy checklist to ensure your PR goes smoothly.

• I signed Google's Contributor License Agreement
• My code conforms to Google's python style.
• My PR at a minimum doesn't decrease unit-test coverage (if applicable).
• My PR has been functionally tested.
• All of the unit-tests still pass.
• Running pylint --rcfile=pylintrc passes.

These guidelines and more can be found in our contributing guidelines.

[blueandgold]

Looks great overall, thanks for adding this! A couple of comments:

Is there a need to also want to update the sql query here?
https://github.com/GoogleCloudPlatform/forseti-security/blob/dev/google/cloud/security/common/data_access/sql_queries/select_data.py#L102

A few unit tests for the IAP scanner looks like they need to be updated. Is that something you can tackle? Or if not, we can help.

[RajUmadas]

@blueandgold thanks. Ill take a stab at the IAP tests today.

[codecov]

Codecov Report

Merging #659 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             dev     #659      +/-   ##
=========================================
+ Coverage   83.7%   83.71%   +<.01%     
=========================================
  Files        165      165              
  Lines       8354     8355       +1     
=========================================
+ Hits        6993     6994       +1     
  Misses      1361     1361

Impacted Files	Coverage Δ
...rity/common/data_access/sql_queries/select_data.py	100% <ø> (ø)	⬆️
...ty/common/data_access/sql_queries/create_tables.py	100% <ø> (ø)	⬆️
...le/cloud/security/common/data_access/csv_writer.py	92.3% <ø> (ø)	⬆️
...le/cloud/security/common/gcp_type/firewall_rule.py	100% <100%> (ø)	⬆️

[codecov]

Codecov Report

Merging #659 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             dev     #659      +/-   ##
=========================================
+ Coverage   83.7%   83.71%   +<.01%     
=========================================
  Files        165      165              
  Lines       8354     8355       +1     
=========================================
+ Hits        6993     6994       +1     
  Misses      1361     1361

Impacted Files	Coverage Δ
...rity/common/data_access/sql_queries/select_data.py	100% <ø> (ø)	⬆️
...ty/common/data_access/sql_queries/create_tables.py	100% <ø> (ø)	⬆️
...le/cloud/security/common/data_access/csv_writer.py	92.3% <ø> (ø)	⬆️
...le/cloud/security/common/gcp_type/firewall_rule.py	100% <100%> (ø)	⬆️

[blueandgold]

Super awesome, thanks for the fixing the query and the tests!

[blueandgold]

PS: this should go out into this week's release. Thanks again!

[gbrindisi]

@RajUmadas @blueandgold thanks for this!