This repository has been archived by the owner on Jun 5, 2023. It is now read-only.
Api additions - Get Networks #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the ability to get a list of networks via the api and tests to verify data.
Re made the fake responses to work with pagenation.
Changed get_networks from beta to v1, removed the subnetworks test.
Forgot to remove the fake data for the subnetworks before last push.
Codecov Report
@@ Coverage Diff @@
## dev #677 +/- ##
=========================================
+ Coverage 83.7% 83.72% +0.02%
=========================================
Files 165 165
Lines 8359 8370 +11
=========================================
+ Hits 6997 7008 +11
Misses 1362 1362
|
ahoying
reviewed
Oct 2, 2017
| "kind": "compute#network", | ||
| "id": "1234", | ||
| "creationTimestamp": "2017-09-25T12:41:09.416-07:00", | ||
| "name": "default2", |
There was a problem hiding this comment.
nit: name should match selflink, change from default2 to thisisatest and update the expected names below.
| @@ -194,6 +195,16 @@ def firewalls(self): | |||
| return self._firewalls | |||
|
|
|||
| @property | |||
| def networks(self): | |||
| """Returns a _ComputeNetworksRepository instance.""" | |||
| # The beta api provides more complete gcp networks data. | |||
There was a problem hiding this comment.
nit: Comment is out of date, no longer needed with the change back to v1.
| @@ -117,6 +117,17 @@ def test_get_firewall_rules_errors(self, name, response, status, | |||
| with self.assertRaises(expected_exception): | |||
| list(self.gce_api_client.get_firewall_rules(self.project_id)) | |||
|
|
|||
| def test_get_networks(self): | |||
There was a problem hiding this comment.
Please add a test for the error cases as well, like test_get_firewall_rules_errors above.
Added the test_get_network_errors test to verify error condidtions for get networks
ahoying
approved these changes
Oct 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for opening a Pull Request!
Here's a handy checklist to ensure your PR goes smoothly.
pylint --rcfile=pylintrcpasses.These guidelines and more can be found in our contributing guidelines.