Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests without secure-node #245

Merged
merged 9 commits into from Oct 16, 2020
Merged

Fix tests without secure-node #245

merged 9 commits into from Oct 16, 2020

Conversation

erikarvstedt
Copy link
Collaborator

This PR is based on #243 Modularize Tests.
It fixes the tests for scenarios without secure-node.

The following is now working:

test/run-tests.sh -s full
test/run-tests.sh -s bitcoind

cat > /tmp/scenarios <<EOF
{...}: {
  custom = {
    services.electrs.enable = true;
    services.lnd.enable = true;
  };
}
EOF
scenarioOverridesFile=/tmp/scenarios test/run-tests.sh -s custom

@erikarvstedt erikarvstedt force-pushed the fix-tests branch 14 times, most recently from e013d6e to 3e1b848 Compare September 30, 2020 09:51
@nixbitcoin
Copy link
Member

Concept ACK.

Once #243 has been merged you should rebase, and then I'll ACK.

@erikarvstedt
modules: group imports
2dd1a74
@erikarvstedt
extract operator module
9aa19c3
@erikarvstedt
test: add python test requirements
c07e767 
This allows running the Python tests without importing secure-node.
@erikarvstedt
liquid: fix bitcoin rpc settings
480d0d3 
- Remove redundant option mainchainrpchost.
  This option is already provided by bitcoind.
- Set a working default for rpcport and rpcuser.
  Enables use without secure-node.
@erikarvstedt
spark-wallet: fix always-on onion-chef setting
e0117d5 
Previously, the service failed when onion-service was disabled.
@erikarvstedt
clightning: add option 'extraConfig'
7d1797c
@erikarvstedt
test: speed up clightning startup when offline
1a32292
@erikarvstedt
run-tests: simplify setting default scenario
0a6b9be
@erikarvstedt
run-tests: add command 'all'
bfed10b 
'all' includes test 'full', which now succeeds.
jonasnick
jonasnick reviewed Oct 16, 2020
View reviewed changes
Copy link
Member

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Looks good to me so far.

test/run-tests.sh
scenario=default buildTest "$@"
scenario=netns buildTest "$@"
scenario=full buildTest "$@"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 min 30 vs 3 min 15 on my laptop so we can switch to all by default in the future if we miss issues with the full test.

@erikarvstedt
Copy link
Collaborator Author

Rebased to master.

jonasnick
jonasnick approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bfed10b

@erikarvstedt erikarvstedt mentioned this pull request Oct 16, 2020
Merged
@jonasnick jonasnick merged commit 6a16f60 into fort-nix:master Oct 16, 2020
@erikarvstedt erikarvstedt deleted the fix-tests branch December 15, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasnick jonasnick jonasnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erikarvstedt @nixbitcoin @jonasnick