Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set MBEDTLS_SSL_OUT_CONTENT_LEN to a smaller value to avoid client side record overflow #294

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Set MBEDTLS_SSL_OUT_CONTENT_LEN to a smaller value to avoid client side record overflow #294

merged 1 commit into from
Jul 12, 2023

Conversation

Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Jul 11, 2023 •
edited
Loading

In some cases, mbedlts will send a tls record with record length > 2^14 which breaks the rfc, as a result trigger client's record overflow error. This PR is a temporary fix for it

@Taowyoo Taowyoo added the bug label Jul 11, 2023
@Taowyoo Taowyoo self-assigned this Jul 11, 2023
@Taowyoo Taowyoo linked an issue Jul 11, 2023 that may be closed by this pull request
[mbedtls3] mbedlts would breaks the record size limit when sending big record #293
Open
arai-fortanix
arai-fortanix reviewed Jul 11, 2023
View reviewed changes
Copy link

@arai-fortanix arai-fortanix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain how this fixes the issue? Does mbedtls already support MBEDTLS_SSL_OUT_OUT_CONTENT_LEN if it's set?

@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Jul 11, 2023

Hi @arai-fortanix , yes, it's provide by mbedtls, originally we did not set it and it was configured to default value of 2^14

@Taowyoo Taowyoo enabled auto-merge July 12, 2023 00:08
@Taowyoo Taowyoo added this pull request to the merge queue Jul 12, 2023
Merged via the queue into master with commit b533128 Jul 12, 2023
5 checks passed
@jethrogb jethrogb mentioned this pull request Jul 12, 2023
Open
@Taowyoo Taowyoo deleted the yx/ssl_out_content_length branch October 20, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arai-fortanix arai-fortanix arai-fortanix approved these changes

@jethrogb jethrogb Awaiting requested review from jethrogb

@mzohreva mzohreva Awaiting requested review from mzohreva

Assignees

@Taowyoo Taowyoo

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mbedtls3] mbedlts would breaks the record size limit when sending big record
2 participants
@Taowyoo @arai-fortanix