Cancel queue #286
Closed
Cancel queue #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzohreva
force-pushed
the
mz/impl_fifo
branch
from
e1e8150
to
00055a3
Compare
mzohreva
force-pushed
the
mz/cancel_queue
branch
from
e03e80e
to
5e0efc2
Compare
mzohreva
force-pushed
the
mz/impl_fifo
branch
from
16a16b4
to
b78ed4b
Compare
mzohreva
force-pushed
the
mz/cancel_queue
branch
2 times, most recently
from
8094551
to
7ab942c
Compare
mzohreva
force-pushed
the
mz/cancel_queue
branch
from
7ab942c
to
c37d9ac
Compare
jethrogb
reviewed
Oct 8, 2020
jethrogb
reviewed
Oct 9, 2020
| @@ -453,6 +453,10 @@ pub const EV_RETURNQ_NOT_EMPTY: u64 = 0b0000_0000_0000_0010; | |||
| /// An event that enclaves can use for synchronization. | |||
| #[cfg_attr(feature = "rustc-dep-of-std", unstable(feature = "sgx_platform", issue = "56975"))] | |||
| pub const EV_UNPARK: u64 = 0b0000_0000_0000_0100; | |||
| /// An event that will be triggered by userspace when the cancel queue is not | |||
| /// or no longer full. | |||
There was a problem hiding this comment.
I didn't check the exact language when looking at the other queue. Are we correctly handling the “not full” case? i.e. this phrasing suggests that if the enclave calls wait on a queue event and there is no event pending but the queue is not empty/full, an event should be generated immediately.
There was a problem hiding this comment.
I don't think we do that in the implementation. It's based on the assumption that the enclave would only issue a wait usercall with NOT_EMPTY/NOT_FULL only after trying to send/recv on a queue. But I don't think it would be too difficult to change this. We'd need some way of getting the queue's empty/full state in fn wait.
mzohreva
force-pushed
the
mz/cancel_queue
branch
from
c37d9ac
to
95b558e
Compare
jethrogb
reviewed
Oct 28, 2020
mzohreva
force-pushed
the
mz/cancel_queue
branch
from
95b558e
to
57b0325
Compare
mzohreva
force-pushed
the
mz/cancel_queue
branch
from
e741386
to
2639806
Compare
mzohreva
force-pushed
the
mz/cancel_queue
branch
from
2639806
to
4908696
Compare
|
Close this since this is done by #515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of PR #246 and adds a third queue for cancelling blocked usercalls.