Fix typo in dcap-ql dependency

[raoulstrackx]

A typo in the specification of the mbedtls dependency of dcap-ql may lead to a compilation error.

Fixes #497
cc: @Taowyoo @jethrogb @vn971 @mkaynov

[maxknv]

LGTM

[kostko]

Would be cool if there was a build check as part of CI :)

[raoulstrackx]

Would be cool if there was a build check as part of CI :)

Yes I totally agree. Unfortunately, the way features get enabled in a workspace, makes it difficult. Did you have a test in mind that reproduced the compilation error?

[Taowyoo]

The default std I added for mbedtls in dcap-ql is for avoiding the compiling error when compile the dcap-ql with only verify and with mbedtls specify with default-features = false in a crate e.g.:

[package]
name = "dcap-ql-fail"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
dcap-ql = { version = "0.3.6", default-features = false, features = ["verify"] }
mbedtls = { version = "0.9.0", default-features = false}

Because mbedtls needs at least one of std or no_std_deps features is defined.

Reason
After some research, the problem actually is from cargo. cargo will automatically include dev dependencies when running cargo build. Ref: rust-lang/cargo#4988

So cargo build -p dcap-ql --no-default-features --features verify will succeed since there is a dev dependency of mbedtls with default feature.

And if use cargo build -p dcap-ql --no-default-features --features verify -Z avoid-dev-deps to exclude dev dependencies , then I found some other dependencies also has this problem which cause compilation failed.

And seems current only way is:

For people who are using stable version numbers to cargo check MSRV (so can't use nightly), there is a dirty hacky workaround.

[Taowyoo]

bors r+

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• continuous-integration/travis-ci/push

[Taowyoo]

Created an issue for the build check problem above : #499